Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow firebase-admin v12 #1473

Closed
wants to merge 3 commits into from
Closed

Conversation

luc122c
Copy link
Contributor

@luc122c luc122c commented Dec 8, 2023

The Firebase Admin SDK for Node has been bumped to v12. This currently leads to unmet peer dependency warnings:

 WARN  Issues with peer dependencies found
 
└─┬ nuxt-vuefire 1.0.0
  └── ✕ unmet peer firebase-admin@^11.3.0: found 12.0.0

This PR adds v12 to the allowed ranges.

@posva
Copy link
Member

posva commented Dec 8, 2023

Thanks! It looks like firebase-functions are still not supporting firebase-admin 12, so we will have to wait a bit longer. I pushed changes to actually change the peer dep (it wasn't changed)

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e2c71e) 75.93% compared to head (96a6de4) 75.93%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   75.93%   75.93%           
=======================================
  Files          21       21           
  Lines        3387     3387           
  Branches      263      263           
=======================================
  Hits         2572     2572           
  Misses        815      815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luc122c
Copy link
Contributor Author

luc122c commented Dec 8, 2023

I pushed changes to actually change the peer dep (it wasn't changed)

Oops, missed that! Thanks :)

@luc122c
Copy link
Contributor Author

luc122c commented Dec 8, 2023

Thanks! It looks like firebase-functions are still not supporting firebase-admin 12, so we will have to wait a bit longer.

It looks like there is a PR tracking this: firebase/firebase-functions#1496

@posva
Copy link
Member

posva commented Jan 3, 2024

Thanks for the PR. I will locally update once the upstream issue is fixed.

@posva posva closed this Jan 3, 2024
@luc122c luc122c deleted the firebase-admin-12 branch January 5, 2024 00:46
@prvashisht
Copy link

prvashisht commented Mar 3, 2024

@luc122c
Copy link
Contributor Author

luc122c commented Jun 16, 2024

@posva Is there any chance this could be looked at again please?

@luc122c luc122c restored the firebase-admin-12 branch June 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants